add 1s delay to start of key autos#366
Open
aschokking wants to merge 3 commits intomainfrom
Open
Conversation
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
src/main/java/competition/auto_programs/vision/RightFourCoralAuto.java:30
- [nitpick] Consider extracting the delay duration into a named constant to avoid magic numbers and simplify future adjustments.
this.addCommands(new WaitCommand(Seconds.of(1)));
src/main/java/competition/auto_programs/vision/LeftFourCoralAuto.java:31
- [nitpick] Consider extracting the delay duration into a named constant to avoid magic numbers and simplify future adjustments.
this.addCommands(new WaitCommand(Seconds.of(1)));
src/main/java/competition/auto_programs/FromCageScoreOneCoralAutoFactory.java:44
- [nitpick] Consider extracting the delay duration into a named constant to avoid magic numbers and simplify future adjustments.
auto.addCommands(new WaitCommand(Seconds.of(1)));
stephenjust
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are we doing this?
Especially with the deadwheels on, we were seeing what looked like overruns causing erratic driving behavior at the start of auto. This PR adds back in a 1s delay to hopefully wait out the storm.
Asana task URL:
Whats changing?
Questions/notes for reviewers
How this was tested
Video/screenshots (from simulator or live robot)
PR feedback legend